Skip to content

harness/new: honest conformance timeout + cheaper contract test (fixes for #3006) - #3007

Merged
asim merged 1 commit into
codex/assess-go-micro-project-for-development-strategyfrom
claude/loving-meitner-3Etoi
Jun 24, 2026
Merged

asim merged 1 commit into
codex/assess-go-micro-project-for-development-strategyfrom
claude/loving-meitner-3Etoi

Conversation

@asim

@asim asim commented Jun 24, 2026

Copy link
Copy Markdown
Member

Mechanical hardening on top of #3006 (stacked — base is the #3006 branch so the diff is just these two fixes). Pairs with the review on #3006.

internal/harness/provider-conformance — build each harness to a temp binary and run that instead of go run. go run launches the compiled harness as a child it doesn't kill on context cancellation, so a timed-out harness (which starts local services/listeners) could be orphaned and outlive the run. Building + exec'ing the binary makes the per-run timeout actually terminate the work.

cmd/micro/cli/new/contract_test.go — two changes:

  • Skip under -short, so the default unit-test suite doesn't shell out to the Go toolchain + network on every run (the contract test runs go mod tidy via Run and then compiles a generated service).
  • Use go build ./... instead of go test ./... — the contract is that the generated service builds, and go build is sufficient and lighter.

Verified: go build ./..., golangci-lint run (0 issues, incl. the now-blocking lint), go test -short ./cmd/micro/cli/new/ skips fast, and go run ./internal/harness/provider-conformance -providers mock still passes.

Merge order: either merge this into the #3006 branch first, or merge #3006 to master and I'll re-target this to master.

🤖 Generated with Claude Code


Generated by Claude Code

Follow-up to #3006:

- provider-conformance: build each harness to a temp binary and run that
  instead of 'go run'. 'go run' launches the harness as a child it doesn't
  kill on context cancellation, so a timed-out harness (which starts local
  services) could be orphaned and outlive the run. Running the built binary
  makes the per-run timeout actually terminate the work.
- contract test: skip under -short, and use 'go build ./...' instead of
  'go test ./...' (the contract is that the generated service builds). This
  keeps the default unit-test suite from shelling out to the toolchain and
  the network on every run.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CmdEY7pYmV5zzwCjNJ4ykL
@asim
asim merged commit db269c6 into codex/assess-go-micro-project-for-development-strategy Jun 24, 2026
10 checks passed
asim pushed a commit that referenced this pull request Jun 24, 2026
Add matching 'Coordination' sections so Claude Code and Codex self-coordinate:
lane/branch ownership (claude/* vs codex/*, never share a branch), base PRs
on master (don't stack on an in-flight branch — the #3007 orphan lesson),
one concern per PR, cross-review before merge, the @codex dispatch
conventions (review reserved, serial, fix-in-place), and CI as the gate.
asim added a commit that referenced this pull request Jun 24, 2026
…#3016)

Add matching 'Coordination' sections so Claude Code and Codex self-coordinate:
lane/branch ownership (claude/* vs codex/*, never share a branch), base PRs
on master (don't stack on an in-flight branch — the #3007 orphan lesson),
one concern per PR, cross-review before merge, the @codex dispatch
conventions (review reserved, serial, fix-in-place), and CI as the gate.

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants